Fix 'duplicate types' check for properties with a single type #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Kraus <hanzi@hanzi.cc>
Codecov Report
@@ Coverage Diff @@
## master #1399 +/- ##
=======================================
Coverage 62.31% 62.31%
=======================================
Files 4 4
Lines 69 69
=======================================
Hits 43 43
Misses 26 26Continue to review full report at Codecov.
|
skjnldsv
approved these changes
Jan 6, 2020
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1263
The 'duplicate types' check would fail if properties with single-value
TYPEparameters were present,Background
prop.getParameter('type')would return an Array if multiple types are present, but a String if there's only one type:Here,
propis going to be[ 'HOME', 'VOICE' ]. This works.Whereas here,
propwill end up as just'HOME'. If you pass a string intonew Set(), it will create an array containing all the individual characters of the string. So the check ends up effectively doing:This is fixed by moving the
Array.isArraycheck into thefiltercall, so that only properties with multiple types are compared to begin with.I removed some other checks that were unnecessary:
Array.filterandArray.mapalways return an array, sopropsis already guaranteed to be one, and there's no harm in comparing empty arrays.